Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Routing Specs to Website and Fix Broken Links #411

Merged
merged 2 commits into from
May 12, 2023
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented May 12, 2023

I was going to tackle #344, but I found some dragons. This PR moves the routing specifications to the website, and fixes the references in other files (right now we have IPIPs with broken links on the website). It also removes broken links to the old reframe spec.

Please note that the :cite[routing-v1] will only work properly once this is merged and published to the website.

@hacdias hacdias requested a review from lidel May 12, 2023 12:13
@hacdias hacdias requested a review from a team as a code owner May 12, 2023 12:13
@hacdias hacdias changed the title Move Routing Specs to Website Move Routing Specs to Website and Fix Broken Links May 12, 2023
@hacdias hacdias self-assigned this May 12, 2023
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but fix below nit before merging 🙏

routing/ROUTING_V1_HTTP.md Outdated Show resolved Hide resolved
@hacdias hacdias merged commit b07b1bc into main May 12, 2023
@hacdias hacdias deleted the publish-routing branch May 12, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants